fix: bumped shade plugin, fixed clip launch crashing #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unthingable
reviewed
Jun 15, 2024
| @@ -138,7 +138,7 @@ trait ClipMatrix: | |||
| // Util.println(s"lenient calc: $qString $beat $qSize ${beat % (qSize * 4)}") | |||
| Util.println(s"lenient calc: $clipQString $qString $prev $now $next") | |||
| if prev < launchTolerance || (lookAhead > 0 && next < lookAhead) then | |||
| Some(clipQString, "continue_immediately") | |||
| Some(clipQString, "continue_or_from_start") | |||
There was a problem hiding this comment.
Ha, is it just me or Bitwig quietly broke this in an existing API version?
|
Hey, that's awesome! I'm happy this is useful and doubly happy you're digging into the code. Thank you for the PR, I'll get around to merging it in a few days (need to make sure the removal of the duplicate copy target doesn't break the build action in GH). In the meantime you can find me on Bitwig Discord #controllerism. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there 👋
Thanks for this extension I really like the concept and I plan on using it a lot!
But I had to fix a crash when launching a clip.
And in the meantime I also bumped a plugin and removed a copy step in pom since I think it's a duplicate.